Added component label to some resources to disambiguate selectors #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only way to deploy this change is to delete the old previous resources. Below the instruction for staging, needs to be replicated for prod. Note that this will introduce downtime:
|
|
@mbarbero What's next with this one? |
|
It's up to the ops team to decide when then want to to that. |
|
@amvanbaren Thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using the same labels set for both the server deployment and the elasticsearch statefulset. Kubectl CLI is confuses the matching pods when doing requests on deployments or statefulset as it probably uses the selector to find matching pods:
This may also cause confuse the cluster, even though I have no proof of that.
This cannot be deployed as is as the labels of pod templates in deployments and statefulsets cannot be updated once created. I'll provide the steps shortly